Skip to content

Conversation

@snorwin
Copy link
Member

@snorwin snorwin commented Oct 22, 2025

What type of PR is this?

/kind documentation
/kind feature

What this PR does / why we need it:
This PR follows up on #4123 to update the GoDoc comments and introduce a new GatewayConditionType constant of ResolvedRefs, with associated Reason as its own GatewayConditionReason.

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

Add experimental ResolvedRefs condition for Gateway

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: snorwin
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 22, 2025
@snorwin
Copy link
Member Author

snorwin commented Oct 22, 2025

/cc @kl52752 @rikatz

// Possible reasons for this condition to be False are:
//
// * "RefNotPermitted"
// * "InvalidClientCertificateRef"
Copy link
Member Author

@snorwin snorwin Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would also make sense to add a reason (e.g., ListenersNotResolved) to indicate when there are unresolved Listeners. This would allow the condition to serve as a summary of all Listener-level ResolvedRefs conditions.

@snorwin snorwin force-pushed the gateway-backend-tls-api branch from 11ba606 to bc1e880 Compare October 23, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants