generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 536
Updating ngrok Gateway API Implementation on Implementations page #3775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samcrichard
wants to merge
1
commit into
kubernetes-sigs:main
Choose a base branch
from
samcrichard:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -473,15 +473,20 @@ If you have any suggestions or experience issues with NGINX Gateway Fabric, plea | |||
|
||||
### ngrok Kubernetes Operator | ||||
|
||||
[ngrok Kubernetes Operator][ngrok-k8s-operator] provides an implementation of the Gateway API that uses [ngrok's ingress-as-a-service][ngrok]. This project uses the Gateway API to support routing traffic from ngrok's global network to applications running on Kubernetes clusters. This easily adds the benefits of ngrok, like security, network policy, and a global presence with the simplicity of cloud service. The operator contains both a Gateway API implementation as well as a controller using Kubernetes Ingress. The Gateway API implementation is currently under development and supports only the Gateway, GatewayClass and HTTPRoute. As the TLSRoute and TCPRoute move from experimental to stable, they will also be implemented. | ||||
[ngrok Kubernetes Operator][ngrok-k8s-operator] After adding preliminary support last year, the [ngrok Kubernetes Operator][ngrok-k8s-operator] supports the entire core Gateway API. This includes: | ||||
-Routes (HTTPRoute, TCPRoute, TLSRoute) + RouteMatches (Header, Path, +more) | ||||
-Filters: Header, Redirect, Rewrite + more | ||||
-Backends: Backend Filters + Weighted balancing | ||||
-ReferenceGrant: RBAC for multi-tenant clusters handling | ||||
-Traffic Policy as an extensionRef or annotation when the Gateway API isn’t flexible enough | ||||
|
||||
You can read our [docs][ngrok-k8s-gwapi-docs] for more information. If you have any feature requests or bug reports, please [create an issue][ngrok-issue-new]. You can also reach out for help on [Slack][ngrok-slack] | ||||
|
||||
[ngrok-k8s-operator]:https://github.com/ngrok/ngrok-operator | ||||
[ngrok]:https://ngrok.com | ||||
[ngrok-k8s-gwapi-docs]:https://ngrok.com/docs/k8s/ | ||||
[ngrok-issue-new]: https://github.com/ngrok/ngrok-operator/issues/new/choose | ||||
[ngrok-slack]:https://ngrokcommunity.slack.com/channels/general | ||||
|
||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
|
||||
### STUNner | ||||
|
||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal, but just a heads up that in the list below, you included some features that are not core (
TCPRoute
,TLSRoute
, ...). If you are fine with the current wording, I'm fine as well :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, let's go with it