Enhance pool namespace resolution: use flag if set, else NAMESPACE en… #1578

jyizheng · 2025-09-12T17:39:41Z

What type of PR is this?

feature

What this PR does / why we need it:
Provides a convenient default without the need to explicitly set when running in a namespace other than default.
Use flag (--pool-namespce) if set, else NAMESPACE env var, else default; add documentation for behavior

Which issue(s) this PR fixes:

#1569

Does this PR introduce a user-facing change?:
NONE

…v var, else default; add documentation for behavior

netlify · 2025-09-12T17:39:47Z

✅ Deploy Preview for gateway-api-inference-extension ready!

Name	Link
🔨 Latest commit	`166f784`
🔍 Latest deploy log	https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68c4c0d8c0648e000824d76a
😎 Deploy Preview	https://deploy-preview-1578--gateway-api-inference-extension.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

linux-foundation-easycla · 2025-09-12T17:39:47Z

The committers listed above are authorized under a signed CLA.

✅ login: jyizheng / name: Yizheng Jiao (d35bf2d, bc3edc0, 166f784, 783d89f, 25f2d03, a9f2308)

k8s-ci-robot · 2025-09-12T17:39:50Z

Welcome @jyizheng!

It looks like this is your first PR to kubernetes-sigs/gateway-api-inference-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api-inference-extension has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2025-09-12T17:39:51Z

Hi @jyizheng. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ahg-g · 2025-09-12T18:08:18Z

cmd/epp/runner/runner.go

@@ -188,9 +188,16 @@ func (r *Runner) Run(ctx context.Context) error {
 		FilterProvider: filters.WithAuthenticationAndAuthorization,
 	}

+	// Determine pool namespace: flag > NAMESPACE env var > default


the user may intentionally set the default in the flag, the logic below doesn't account for that

Got it. Just changed my code.

liu-cong · 2025-09-12T18:21:25Z

cmd/epp/runner/runner.go

@@ -188,9 +188,16 @@ func (r *Runner) Run(ctx context.Context) error {
 		FilterProvider: filters.WithAuthenticationAndAuthorization,
 	}

+	// Determine pool namespace: flag > NAMESPACE env var > default
+	resolvedPoolNamespace := *poolNamespace
+	if resolvedPoolNamespace == runserver.DefaultPoolNamespace {


we should just check if flag is nil/empty string.

Make sense. Just fixed it.

ahg-g · 2025-09-12T19:24:56Z

/ok-to-test

liu-cong · 2025-09-12T20:04:18Z

cmd/epp/runner/runner.go

+	// Determine pool namespace: if flag set, use it; else NAMESPACE env var; else default
+	resolvedPoolNamespace := ""
+	poolNamespaceFlagSet := false
+	flag.Visit(func(f *flag.Flag) {


Can we do something like this? No need to check the flag name I think.

func resolvePoolNamespace() string { // check if --pool-namespace flag is set if *poolNamespace != "" { return *poolNamespace } // Check if NAMESPACE env var is set nsEnv := os.Getenv("NAMESPACE") if nsEnv != "" { return nsEnv } // Fallback to default return runserver.DefaultPoolNamespace }

Oh to do this we should set the default value of the flag to "", which I think we we should do.

gateway-api-inference-extension/cmd/epp/runner/runner.go

Line 83 in 35b14a1

poolNamespace = flag.String("pool-namespace", runserver.DefaultPoolNamespace, "Namespace of the InferencePool this Endpoint Picker is associated with.")

Sorry pls see my last comment we should set the default value of the flag to "", right now the flag is defaulted to default so it will never be empty. We should change that, otherwise it's misleading.

Got it. Just replace runserver.DefaultPoolNamespace with empty string. Is this ok?

…r, else default

liu-cong · 2025-09-12T22:05:05Z

docs/pool-namespace-behavior.md

Sorry one last comment, I suggest we add a new flags.md doc under https://github.com/kubernetes-sigs/gateway-api-inference-extension/tree/main/site-src/guides/epp-configuration, this is where we document how to configure the EPP binary.

In flags.md we can just start with the pool-namespace flag. Most flags should be self explanatory in their flag description so we don't need to document everything.

I see. File relocated.

liu-cong · 2025-09-15T16:48:48Z

Thanks @jyizheng !

/lgtm

@ahg-g Can you approve if this looks good?

ahg-g · 2025-09-15T20:20:13Z

/approve

k8s-ci-robot · 2025-09-15T20:20:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, jyizheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ahg-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ahg-g · 2025-09-15T20:21:21Z

as a followup, can you please update the helm chart of the epp deployment to add the namespace envvar?

Enhance pool namespace resolution: use flag if set, else NAMESPACE en…

d35bf2d

…v var, else default; add documentation for behavior

k8s-ci-robot requested review from ahg-g and liu-cong September 12, 2025 17:39

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 12, 2025

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 12, 2025

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Sep 12, 2025

ahg-g reviewed Sep 12, 2025

View reviewed changes

liu-cong reviewed Sep 12, 2025

View reviewed changes

address comments

a9f2308

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2025

liu-cong reviewed Sep 12, 2025

View reviewed changes

jyizheng added 3 commits September 12, 2025 20:10

treat empty string as unset, use flag value if non-empty, else env va…

783d89f

…r, else default

address comments

bc3edc0

update doc

25f2d03

liu-cong reviewed Sep 12, 2025

View reviewed changes

relocate document

166f784

k8s-ci-robot assigned liu-cong Sep 15, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2025

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2025

k8s-ci-robot merged commit 0ed667e into kubernetes-sigs:main Sep 15, 2025
9 checks passed

ahg-g mentioned this pull request Sep 16, 2025

Use env var for DefaultPoolNamespace with fallback to default #1599

Closed

liu-cong mentioned this pull request Sep 16, 2025

Set EPP NAMESPACE env var in helm charts #1569

Open

Enhance pool namespace resolution: use flag if set, else NAMESPACE en… #1578

Enhance pool namespace resolution: use flag if set, else NAMESPACE en… #1578

Conversation

jyizheng commented Sep 12, 2025

Uh oh!

netlify bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for gateway-api-inference-extension ready!

Uh oh!

linux-foundation-easycla bot commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Sep 12, 2025

Uh oh!

k8s-ci-robot commented Sep 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahg-g commented Sep 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

liu-cong commented Sep 15, 2025

Uh oh!

ahg-g commented Sep 15, 2025

Uh oh!

k8s-ci-robot commented Sep 15, 2025

Uh oh!

ahg-g commented Sep 15, 2025

Uh oh!

Uh oh!

Uh oh!

netlify bot commented Sep 12, 2025 •

edited

Loading

linux-foundation-easycla bot commented Sep 12, 2025 •

edited

Loading