Skip to content

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Oct 4, 2025

What does it do ?

Moved source wrapper logic away from controller. I was trying to figure out if there is an easy way to chain handlers, seems like the logical step is to move specific logic to source/wrappers folder.

  • moved build logic to source/wrappers
  • added more tests cases

Motivation

Relates #5809

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added the apis Issues or PRs related to API change label Oct 4, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 4, 2025
@k8s-ci-robot k8s-ci-robot requested a review from szuecs October 4, 2025 15:49
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added controller Issues or PRs related to the controller source size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 4, 2025
@ivankatliarchuk
Copy link
Contributor Author

/retest

@coveralls
Copy link

coveralls commented Oct 4, 2025

Pull Request Test Coverage Report for Build 18246594909

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 78.605%

Files with Coverage Reduction New Missed Lines %
apis/externaldns/types.go 1 99.71%
execute.go 3 61.28%
Totals Coverage Status
Change from base Build 18242454154: 0.05%
Covered Lines: 15846
Relevant Lines: 20159

💛 - Coveralls

@ivankatliarchuk ivankatliarchuk changed the title refactor(source/wrappers): move wrappers away from refactor(source/wrappers): move wrappers logic away from execute file Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apis Issues or PRs related to API change cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. controller Issues or PRs related to the controller size/L Denotes a PR that changes 100-499 lines, ignoring generated files. source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants