-
Notifications
You must be signed in to change notification settings - Fork 1.4k
✨ Add in-place updates support for machine controller #12831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
✨ Add in-place updates support for machine controller #12831
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7bb3062 to
b5b0b04
Compare
internal/controllers/machine/machine_controller_inplace_update.go
Outdated
Show resolved
Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go
Outdated
Show resolved
Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go
Outdated
Show resolved
Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go
Outdated
Show resolved
Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go
Outdated
Show resolved
Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go
Outdated
Show resolved
Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go
Outdated
Show resolved
Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go
Outdated
Show resolved
Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go
Outdated
Show resolved
Hide resolved
a88faa8 to
ed1835e
Compare
internal/controllers/machine/machine_controller_inplace_update.go
Outdated
Show resolved
Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go
Outdated
Show resolved
Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go
Outdated
Show resolved
Hide resolved
internal/controllers/machine/machine_controller_inplace_update.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexandr Demicev <[email protected]>
ed1835e to
9bd69f3
Compare
|
@sbueringer all comments addressed |
|
I think you can go ahead and add unit test coverage |
| // Support for multiple extensions will be introduced in a future iteration. | ||
| extensions, err := r.RuntimeClient.GetAllExtensions(ctx, runtimehooksv1.UpdateMachine, s.machine) | ||
| if err != nil { | ||
| return ctrl.Result{}, "", errors.Wrap(err, "failed to get registered UpdateMachine extensions") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| return ctrl.Result{}, "", errors.Wrap(err, "failed to get registered UpdateMachine extensions") | |
| return ctrl.Result{}, "", err |
I think the error build inside of GetAllExtensions already has enough context, this would just repeat it a bit
What this PR does / why we need it:
Part of #12291
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #