🌱 Removed disabled usetesting in golangci.yaml, fixing linting issues

[PatrickLaabs]

What this PR does / why we need it:
After the PR #3469 has been merged, I removed the disabled "usetesting" in the config file, and fixed all the various linting issues that came across.

Mostly, it has been replacements of context.Background() to t.Context() and a few os.CreateTemp("", ...) to os.CreateTemp(t.TempDir(), ...)
Which issue(s) this PR fixes:
Fixes #3470

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @PatrickLaabs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sbueringer]

/ok-to-test

Thx!

/hold
for kubernetes-sigs/cluster-api#12219 (comment)

[PatrickLaabs]

/test pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-main

[PatrickLaabs]

@sbueringer Shall I also investigate, if we are able to remove 'ctrl.SetupSignalHandler()' for the vsphere provider?

[sbueringer]

@sbueringer Shall I also investigate, if we are able to remove 'ctrl.SetupSignalHandler()' for the vsphere provider?

I think the answer should be the same as for core CAPI. I would just like to figure out our policy via core CAPI and then align here

(I'm very very low on bandwidth at the moment, we're trying to finish v1beta2 in time..)

[PatrickLaabs]

No Problem. I guess this fix isn't critical for the next release, therefore it can wait a little longer 😄
Is there anything I can help you with for the v1beta2 release?

[sbueringer]

No Problem. I guess this fix isn't critical for the next release, therefore it can wait a little longer 😄 Is there anything I can help you with for the v1beta2 release?

Thx for offering. Not sure. v1beta2 for CAPV won't be done in v1.14. I think in core CAPI we only have the pretty complicated and big tasks remaining