-
Notifications
You must be signed in to change notification settings - Fork 108
🐛 Update existing conditions to have a non-empty Reason field #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Update existing conditions to have a non-empty Reason field #910
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @PavanNeerudu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PavanNeerudu please fix the lint issues, otherwise LGTM thanks.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d6f24b2
to
a44b0ad
Compare
/lgtm |
LGTM label has been added. Git tree hash: 3089539974166c3f2716b145daa8923ec8f818cc
|
🐛 Update existing conditions to have a non-empty Reason field
What this PR does / why we need it:
This PR fixes a bug where existing Kubernetes conditions could have empty
Reason
fields, which violates the Kubernetes API specification brought in #880. The Kubernetes condition API requires that all conditions must have a non-emptyReason
field.The fix adds a
normalizeExistingConditions
function that:Reason
field to the condition type name if it's emptyWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #