✨ Use Secret as provider cache #827
Merged
+372
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
k8s-ci-robot
added
cncf-cla: yes
3 tasks
Signed-off-by: Danil-Grigorev <[email protected]>
Signed-off-by: Danil-Grigorev <[email protected]>
Signed-off-by: Danil-Grigorev <[email protected]>
Signed-off-by: Danil-Grigorev <[email protected]>
Signed-off-by: Danil-Grigorev <[email protected]>
Danil-Grigorev
force-pushed
the
config-map-cache-hash-wip
branch
from
dcf3ae6 to
f4cbe27
Compare
k8s-ci-robot
removed
the
needs-rebase
Signed-off-by: Danil-Grigorev <[email protected]>
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Danil-Grigorev
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Signed-off-by: Danil-Grigorev <[email protected]>
Danil-Grigorev
changed the title
Danil-Grigorev
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
This was referenced Jun 24, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-demicev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 40d6e67d080e01ba850278e4e9c9c6451bc5f6a5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR implements caching approach based on a
Secretresource, capable of re-applying capi-operator managed manifests without performance/memory/network (access to external repositories) overhead. This allows all provider manifests to be templated once, and unless there is a change in the provider spec, referenced credentials/env secret content, the reconcile simply applies provider data on top of existing cluster state.This operation is much cheaper in terms of memory usage, then current templating pipeline from
clusterctl, and it implemented as aphaseon top of existing reconcile process, allowing minimal code changes.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes rancher/highlander#133