Skip to content

feature: add ssl redirect port to IngressClassParams #4308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feature: add ssl redirect port to IngressClassParams #4308

wants to merge 4 commits into from
+294 −2

Conversation

1ms-ms
Copy link
Contributor

@1ms-ms 1ms-ms commented Aug 13, 2025

Issue

#2311

Description

Adding possibility to set sslRedirectPort with ingressClassParams instead of relying on annotations. Follow up to #4290, will partially solve #2311

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 1ms-ms
Once this PR has been reviewed and has the lgtm label, please assign zac-nixon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 13, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @1ms-ms. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 13, 2025
@wweiwei-li
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 20, 2025
wweiwei-li
wweiwei-li reviewed Aug 20, 2025
View reviewed changes
pkg/ingress/model_builder_test.go
@@ -4914,18 +4914,22 @@ func Test_defaultModelBuildTask_buildSSLRedirectConfig(t *testing.T) {
wantErr: nil,
},
{
name: "single Ingress with ssl-redirect annotation",
name: "single Ingress with IngressClassParam for ssl-redirect",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a new test for case single Ingress with IngressClassParam for ssl-redirect, while preserving the existing annotation-based test single Ingress with ssl-redirect annotation.

@1ms-ms
Copy link
Contributor Author

1ms-ms commented Aug 20, 2025

/test pull-aws-load-balancer-controller-e2e-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wweiwei-li wweiwei-li wweiwei-li left review comments

@oliviassss oliviassss Awaiting requested review from oliviassss

@zac-nixon zac-nixon Awaiting requested review from zac-nixon

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1ms-ms @k8s-ci-robot @wweiwei-li