Skip to content

feat: Use WMI to implement Service related System APIs to reduce PowerShell overhead #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

laozc
Copy link
Contributor

@laozc laozc commented Jun 2, 2025

What type of PR is this?
/kind feature

What this PR does / why we need it:
Use WMI to implement Service related System APIs to reduce PowerShell overhead

Which issue(s) this PR fixes:
Partially for #193

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 2, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: laozc
Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@laozc laozc changed the title Use WMI to implement Service related System APIs to reduce PowerShell overhead feat: Use WMI to implement Service related System APIs to reduce PowerShell overhead Jun 2, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 2, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @laozc. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 2, 2025
@mauriciopoppe
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 4, 2025
@mauriciopoppe
Copy link
Member

Do you have a point of contact inside Broadcom that can help review your work?

@randomvariable
Copy link

/lgtm

@k8s-ci-robot
Copy link
Contributor

@randomvariable: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@randomvariable
Copy link

Do you have a point of contact inside Broadcom that can help review your work?

this is generally straightforward, we've used this method a lot internally. the docs are here https://learn.microsoft.com/en-us/windows/win32/cimwin32prov/win32-service

@humblec
Copy link
Contributor

humblec commented Jun 9, 2025

@laozc mostly looks good. can we also write some tests for this change?

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 11, 2025
@laozc laozc force-pushed the wmi-process-system-api-service branch from 5cca786 to 9ad5f3f Compare June 12, 2025 03:32
@laozc
Copy link
Contributor Author

laozc commented Jun 12, 2025

Added the interfaces for mock test class in the second PR with some basic unit test.
I believe the integration test also covers the basic testing for Start/Stop service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants