006-filter-api-to-expose-client-sasl-info #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Bentley <[email protected]>
This was referenced Jul 25, 2025
Closed
|
@k-wall @SamBarker please can you take a look at this. I'm very aware that we've already implemented it. It would be good to keep this repo aligned with (or at least not behind) what's actually implemented. |
robobario
approved these changes
Aug 3, 2025
| /** | ||
| * Returns the SASL context for the client connection, or empty if the client | ||
| * has not successfully authenticated using SASL. | ||
| * Filters should use {@link #clientPrincipal()} in preference to this method, unless they require SASL-specific functionality. |
There was a problem hiding this comment.
Maybe the clientPrincipal reference should go from this doc, it's not defined here or in 004
Signed-off-by: Tom Bentley <[email protected]>
SamBarker
reviewed
Aug 7, 2025
Co-authored-by: Sam Barker <[email protected]> Signed-off-by: Tom Bentley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been suggested to break #71 into separate proposals to simplify review etc. This PR adds a proposal for allowing Filters to make use of SASL.