Fix/104256 fix inconsistent comparisons #267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Alchemy/CodeChain/DefPrimitives.h
… (now also partially includes Vectors, Functions, and AtomTables, even though at the moment I dont think you can get an atom table stored in an Atom (Variable)), not completed yet. Also distinguishes between declining and erroring out in a comparison.
….) for the three different type coercion levels
… compilation issue
…ternSubst for doubles (%r) - a bug was discovered in inequality vs equality (all versions, just using (= for example) where (not (= is NOT consistent with (!=, because due to an oversight with a shortcircuit in the code, (!= 1 1 1 0) returns False while (not (= 1 1 1 0)) returns true (essentially instead of not-ing the equality result, its instead failing if any two elements are equal, which really should be its own function
…ny elements were not equal (consistent with their documentation), to be paired with the unit tests in the last commit
…parisons # Conflicts: # Alchemy/CodeChain/Functions.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite incomplete, not all coercion cases are handled yet, and some stuff needs to be moved into other classes (ex, c++ operators for CCVector)