convert: Parse bitfield size in struct members #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vulkan has always had a bunch of `<member>`s which are bit fields with a defined size after a colon, C/C++ syntax. The conversion to `vkxml` never handled these, resulting in the parser to treat this final numeric token as the field name. In some ways that's desired, as `vkxml` does not have a field to represent bitfield sizes and the crate cannot be updated (we should really stop using it in `ash`...). Having a "broken" numeric in the field name like this at least communicates that this data cannot be trusted/used, and on the `ash` side we've always manually redefined structs with bitfields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vulkan has always had a bunch of
<member>s which are bit fields with a defined size after a colon, C/C++ syntax. The conversion tovkxmlnever handled these, resulting in the parser to treat this final numeric token as the field name.In some ways that's desired, as
vkxmldoes not have a field to represent bitfield sizes and the crate cannot be updated (we should really stop using it inash...). Having a "broken" numeric in the field name like this at least communicates that this data cannot be trusted/used, and on theashside we've always manually redefined structs with bitfields.