Skip to content

Add multi-file upload for local files( for server ) #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

puji4810
Copy link

This PR enhances multi-file support and refines resolution parsing logic to improve usability and reliability.

  • Add multi-file upload and refine resolution retrieval

Added multi-file upload functionality, allowing users to upload multiple files at once.


  • Change FilePath type in Desktop.ShowFileDialog result from string to []string

Updated the FilePath field in ShowFileDialog() from string to []string to support multiple file paths.

Note: This change was made to align with the new /api/file api, which accepts []string , but multi-file support for the desktop has not been fully implemented yet.


  • Use regular expressions to ensure accurate extraction of resolution.

Used regular expressions to ensure accurate extraction of resolution, avoiding errors caused by malformed inputs like 1920x1080x.

…o be uploaded at once.

2. Modified the resolution retrieval code to remove a potentially redundant trailing 'x' and use regular expression matching.
…tring

In internal/desktop/subtitle.go, the `FilePath` field in the result of
ShowFileDialog() was changed from `string` to `[]string` to correctly support
returning multiple file paths.

This change fixes the previous limitation of supporting only a single file path,
ensuring the interface can handle scenarios with multiple file paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant