Skip to content

Conversation

@jsbrittain
Copy link
Collaborator

@jsbrittain jsbrittain commented Sep 2, 2025

  • Upgrade to electron 37, node 22, chromedriver 138.
  • Upgrade python to 3.13
  • All other nodemapper/electron-app dependencies have also been upgraded to their most recent versions
  • Update and reconfigure storybook / jest

Resolves #409


  • node-pty build issue with node 22 on windows can be resolved by upgrading to 1.1.0-beta34

@jsbrittain jsbrittain requested a review from Copilot September 3, 2025 13:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades Electron from version 31 to 37, bringing associated updates to Node.js (22), Chromedriver (138), and Python (3.13). The upgrade includes comprehensive dependency updates across the entire codebase.

  • Upgrade core runtime dependencies: Electron 37, Node 22, Chromedriver 138, Python 3.13
  • Update all Node.js dependencies to their latest versions including major MUI and testing framework updates
  • Migrate from legacy MUI Grid to GridLegacy and update Storybook configuration for compatibility

Reviewed Changes

Copilot reviewed 44 out of 52 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
electron-app/package.json Updates Electron to 37.4.0 and associated dependencies
nodemapper/package.json Major dependency updates including MUI v7, React 19, and testing frameworks
builder/pyproject.toml Constrains Snakemake to version <9 for compatibility
nodemapper/src/gui/Settings/RepoOptions.tsx Adapts to new MUI x-data-grid API with updated selection model handling
nodemapper/src/stories/*.tsx Updates Storybook imports for new framework version
nodemapper/jest.config.mjs New Jest configuration replacing TypeScript version
.github/workflows/*.yml Updates CI/CD to use Python 3.13 and Chromedriver 138
Comments suppressed due to low confidence (1)

nodemapper/src/gui/Settings/RepoOptions.tsx:1

  • The colorFor function is called with 'boolean' for a select component, but this should likely be 'string' since select values are typically strings.
import axios from 'axios';

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade electron / node

1 participant