-
Notifications
You must be signed in to change notification settings - Fork 4
Upgrade to electron 37 #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades Electron from version 31 to 37, bringing associated updates to Node.js (22), Chromedriver (138), and Python (3.13). The upgrade includes comprehensive dependency updates across the entire codebase.
- Upgrade core runtime dependencies: Electron 37, Node 22, Chromedriver 138, Python 3.13
- Update all Node.js dependencies to their latest versions including major MUI and testing framework updates
- Migrate from legacy MUI Grid to GridLegacy and update Storybook configuration for compatibility
Reviewed Changes
Copilot reviewed 44 out of 52 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| electron-app/package.json | Updates Electron to 37.4.0 and associated dependencies |
| nodemapper/package.json | Major dependency updates including MUI v7, React 19, and testing frameworks |
| builder/pyproject.toml | Constrains Snakemake to version <9 for compatibility |
| nodemapper/src/gui/Settings/RepoOptions.tsx | Adapts to new MUI x-data-grid API with updated selection model handling |
| nodemapper/src/stories/*.tsx | Updates Storybook imports for new framework version |
| nodemapper/jest.config.mjs | New Jest configuration replacing TypeScript version |
| .github/workflows/*.yml | Updates CI/CD to use Python 3.13 and Chromedriver 138 |
Comments suppressed due to low confidence (1)
nodemapper/src/gui/Settings/RepoOptions.tsx:1
- The colorFor function is called with 'boolean' for a select component, but this should likely be 'string' since select values are typically strings.
import axios from 'axios';
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
for more information, see https://pre-commit.ci
Resolves #409