Support creation of package directly from resources #3097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A slightly awkward implementation, but this allows for direction creation of packages without a base.
justinsb
requested review from
droot,
mengqiy,
martinmaly,
mortent,
natasha41575 and
yuwenma
as code owners
mortent
reviewed
May 9, 2022
| } | ||
|
|
||
| // We currently create the PackageRevision, and then attach the resources | ||
| // TODO: Can we streamline this - create the package with its resources, or maybe return the draft? |
There was a problem hiding this comment.
Could we address this by creating a new task type that could add the resources to the package as apart of creating the initial revision?
There was a problem hiding this comment.
We could, but I worry that it would make the model more complex, in that now some resources are directly created in PackageRevision. That said, we know that patches share some elements of this problem in the reclone-and-replay approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slightly awkward implementation, but this allows for direct creation of packages without a base.