Add byte mode with support for UTF-8 and SJIS encodings for emojis & international characters #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will enable Utf-8 encoded strings option. It fixes many issues related to a text containing non-latin characters.
|
i have been waiting for so long for this, it was a simpler merge than other PR, yet its still voided for no reason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening the PR branch of #141 again:
Add byte mode with support for UTF-8 and SJIS encodings for emojis & international characters
To generate QR code with a broad device support for non-ASCII characters (such as accents in western european languages, emojis and international characters from all around the world) QR codes need to be created in Byte mode with bytes encoded using UTF-8. SJIS is another possible option that is specific for asian languages.
For most langunages, UTF-8 should just work, but there could be devices in Asia that may supprt SJIS better than UTF-8.
I need the support for byte mode with UTF-8 encoding as well.
For now, I have to use a fork as you did not merge this yet.
It fixes many issues related to a text containing non-ASCII characters.
For example, without Byte mode with UTF-8 encoding, the German "Umlaut u" (ü) is encodded as Hex FC, which is the ISO-8859-1 (or latin-1) encoding of "ü".
This appears to work apparently on Android with the Binary Reader app, but may problably not work with other readers, but maybe note on iPhones:
At least, ChatGPT tells that UTF-8 is universally supported, including iOS.
From #141:
Hi @kozakdenys, you wrote Oct 13, 2024:
Could you make due and merge this PR as soon as possible?