Skip to content

fix: panic for unknown backtraces #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: panic for unknown backtraces #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions cli-core/src/loader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,13 @@ impl Loader {
self.address_space_needs_reloading = true;
},
Event::MemoryMapEx { map_id, address, requested_length, mmap_protection, mmap_flags, source, requested_address: _, file_descriptor: _, offset: _ } => {
let backtrace = self.lookup_backtrace( source.backtrace ).unwrap();
let backtrace = match self.lookup_backtrace( source.backtrace ) {
None => {
warn!("cannot file backtrace: id = {}", source.backtrace);
return;
}
Some(backtrace) => backtrace,
};
let source = MapSource {
timestamp: self.shift_timestamp( source.timestamp ),
backtrace,
Expand Down Expand Up @@ -977,15 +983,22 @@ impl Loader {
}
};

let sources = sources.iter().map( |source| {
let backtrace = self.lookup_backtrace( source.source.backtrace ).unwrap();
MapRegionDeallocationSource {
address: source.address,
length: source.length,
source: MapSource {
timestamp: self.shift_timestamp( source.source.timestamp ),
backtrace,
thread: source.source.thread
let sources = sources.iter().filter_map( |source| {
match self.lookup_backtrace( source.source.backtrace ) {
None => {
warn!("cannot file backtrace: id = {}", source.source.backtrace);
None
}
Some(backtrace) => {
Some(MapRegionDeallocationSource {
address: source.address,
length: source.length,
source: MapSource {
timestamp: self.shift_timestamp( source.source.timestamp ),
backtrace,
thread: source.source.thread
}
})
}
}
}).collect();
Expand Down