Add platform and wayland.libDecor init hints #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to add platform hints to my code as follows
I can do this with the extensions:
but I thought I'd also contribute them to your repository if you're willing to take them!
I've actually put the libDecor in its own "wayland" block within InitHints, so it reads like this for normal usage:
I was torn on a name for
platform
, as it's already a property name. I went with simplicity though as we're already in the InitHints block, but it could also beplatformHint
.Additionally, I kept them as properties rather than functions, despite not being able to read the value, as I feel the syntax is nicer, i.e.
platform = GLFW_PLATFORM_XXX
rather thanplatform(GLFW_PLATFORM_XXX)
as everything else is assigning rather than calling.