clangArgumentParser: use shlex to parse commands
#13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokulshan
approved these changes
Feb 14, 2023
kokulshan
requested changes
Feb 14, 2023
mathstuf
force-pushed
the
shlex-parsing-kokulshan
branch
from
2596070 to
eef0519
Compare
Commands in the JSON database may be escaped for the shell. Perform unescaping so that escaped characters don't get mangled.
mathstuf
force-pushed
the
shlex-parsing-kokulshan
branch
from
eef0519 to
ab72e23
Compare
|
Sorry about that; I don't have a Golang toolchain setup on my laptop to test this right now. Hopefully this works now. |
kokulshan
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands in the JSON database may be escaped for the shell. Perform unescaping so that escaped characters don't get mangled.
Resubmission of ejfitzgerald#26.