Stub out Contact::activate_database_account #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents errors on user login.
kohler
force-pushed
the
master
branch
3 times, most recently
from
327216b to
9356ad3
Compare
kohler
force-pushed
the
main
branch
2 times, most recently
from
da9f064 to
c08d686
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/login.phpcallsactivate_database_account()ifsetupPhaseis active according to config.I think the idea is that this creates the DB account if none exists; cf. #22.
The stub prevents users from receiving unexpected HTTP 500 responses at every login.