Format OpenAPI response codes as strings #979
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shalvah
reviewed
Apr 17, 2025
| @@ -142,7 +142,7 @@ public function generateOpenAPISpec(array $groupedEndpoints): string | |||
| /** @var OpenAPISpecWriter $writer */ | |||
| $writer = app()->makeWith(OpenAPISpecWriter::class, ['config' => $this->config]); | |||
| $spec = $writer->generateSpecContent($groupedEndpoints); | |||
| return Yaml::dump($spec, 20, 2, Yaml::DUMP_EMPTY_ARRAY_AS_SEQUENCE | Yaml::DUMP_OBJECT_AS_MAP); | |||
| return Yaml::dump($spec, 20, 2, Yaml::DUMP_EMPTY_ARRAY_AS_SEQUENCE | Yaml::DUMP_OBJECT_AS_MAP | Yaml::DUMP_NUMERIC_KEY_AS_STRING); | |||
There was a problem hiding this comment.
Hmm, are we sure this doesn't break anything else? I'd much rather go the route of ensuring that the response status codes are actually strings, so they get dumped as strings without needing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a smaller pull request derived from #908 .
More information can be found in issue/pull request #907 and #908.