feat: add support to 'sometimes' rule

[max13fr]

Hello,

I added the support for the "sometimes" validator rule that allow to skip all following validators like "required".

Currently, a field with this following rules was consired as required (but it shouldn't) :

• 'consent_cgu' => 'sometimes|accepted'
• 'other_field' => 'sometimes|required|...' ("filled" rule seems better for this case but "filled_if", "filled_with", ... not existing so it's not an universal solution).

It notably fix this issue without any change to follow Laravel behaviour : #343

As Laravel behaviour, the following rules is correctly returned as required : 'badrule'=> 'required|sometimes|...'

Best regard

[shalvah]

Hey, sorry I missed this. I'm a bit reluctant to add another parameter, sometimes to the validation logic. Why not simplify this to: if sometimes is provided, set required to false (unless it was already true) ?

[max13fr]

Hi, no worries.

Why not simplify this to: if sometimes is provided, set required to false (unless it was already true) ?

Because the case "sometimes|accepted" would not be managed for example :

• first "sometimes" set required to false
• then "accepeted" set required to true

As "sometimes" is almost always at the beginning, changing required to false is useless (since it is already false by default) but on the other hand it risks being overwritten behind (accepted, required, ...).

[shalvah]

Can you add a test?

[max13fr]

Hello,

Sorry for the delay, I've been very busy these past few months.

I just added the tests.

Best regards

[shalvah]

I've been very busy these past few months.

Haha, so have I! Thanks!