protoc flag flexibility #80
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR contains three parts
flake.nix For users / developers that use Nix, setup development environment dependencies
wasm_package
protocoption. This enables a custom version ofwasmpackage to be usedgo-plugin/wasm/host.go
Line 34 in 6e1c26d
Never releases this memory. I have a implemented
go-plugin/wasm/plugin.go
Line 34 in 6e1c26d
and
go-plugin/wasm/plugin.go
Line 39 in 6e1c26d
to effectively do a TTL on allocations. The use case I have are many short lived requests. This custom implementation is not always applicable. Hence with this flag it adds flexibility to use implementations of these core functions that are more applicable to use case.
goplugin_known_types This flag enables user to disable go-plugin implementation of known/types. This serves as a way of deprecating these. The use case I have is more assured consistency with https://github.com/piotr-oles/as-proto
For two new flags, both default such that there is no change in behaviour unless user specifies them.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.