Skip to content

Conversation

mattmikolay
Copy link
Contributor

@mattmikolay mattmikolay commented Aug 11, 2025

Description

This PR enables the use of branches with TeamsKit by updating the useMsTeamsAuth hook to include a branch_slug in the encoded state param.

Checklist

  • Tests have been added for new features or major refactors to existing features.

Screenshots or videos

Loom video

Copy link

vercel bot commented Aug 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Project Deployment Preview Comments Updated (UTC)
javascript-ms-teams-connect-example Ready Preview 💬 Add feedback Aug 11, 2025 10:32pm
javascript-nextjs-example Ready Preview 💬 Add feedback Aug 11, 2025 10:32pm
javascript-slack-connect-example Ready Preview 💬 Add feedback Aug 11, 2025 10:32pm
javascript-slack-kit-example Ready Preview 💬 Add feedback Aug 11, 2025 10:32pm

Copy link

linear bot commented Aug 11, 2025

Copy link

changeset-bot bot commented Aug 11, 2025

🦋 Changeset detected

Latest commit: fdf7502

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
ms-teams-connect-example Patch
@knocklabs/react-core Patch
@knocklabs/react Patch
@knocklabs/expo Patch
@knocklabs/react-native Patch
guide-example Patch
nextjs-app-dir-example Patch
nextjs-example Patch
slack-connect-example Patch
slack-kit-example Patch
@knocklabs/expo-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mattmikolay mattmikolay changed the title Update useMsTeamsAuth hook feat(KNO-9332): enable use of TeamsKit with branches Aug 11, 2025
Copy link

linear bot commented Aug 11, 2025

Copy link

codecov bot commented Aug 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.35%. Comparing base (6adce9f) to head (fdf7502).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                                               Coverage Diff                                                @@
##           mattmik-kno-9338-javascript-sdks-add-support-for-x-knock-branch-header-to-js     #705      +/-   ##
================================================================================================================
+ Coverage                                                                         63.34%   63.35%   +0.01%     
================================================================================================================
  Files                                                                               181      181              
  Lines                                                                              7221     7223       +2     
  Branches                                                                            853      853              
================================================================================================================
+ Hits                                                                               4574     4576       +2     
  Misses                                                                             2621     2621              
  Partials                                                                             26       26              
Files with missing lines Coverage Δ
...-core/src/modules/ms-teams/hooks/useMsTeamsAuth.ts 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants