Follow up cleanup of #4516.

[twoGiants]

Finish re-work from PR review for #4516.

Proposed Changes

• set token issues interface method to package scope
• set token issues constructor functions to package scope
• inline test name variables in token issuer tests
• remove unused test case struct members
• remove unused if conditions

[twoGiants]

/cc @creydr

[codecov]

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.10%. Comparing base (150a9bd) to head (94b34ac).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...lane/pkg/security/oauth/msk_access_token_issuer.go	50.00%	1 Missing ⚠️
...pkg/security/oauth/msk_role_access_token_issuer.go	50.00%	1 Missing ⚠️
control-plane/pkg/security/oauth/token_provider.go	66.66%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4553   +/-   ##
=======================================
  Coverage   30.10%   30.10%           
=======================================
  Files         294      294           
  Lines       19543    19543           
=======================================
  Hits         5883     5883           
  Misses      13207    13207           
  Partials      453      453           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[creydr]

/lgtm

Thanks for the cleanup

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, twoGiants

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [creydr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[twoGiants]

/retest-required

[dprotaso]

known flake - #4519

/retest

[twoGiants]

/test reconciler-tests

[creydr]

/test reconciler-tests

[twoGiants]

/test reconciler-tests

[twoGiants]

/test upgrade-tests

[twoGiants]

/test upgrade-tests

[twoGiants]

/test upgrade-tests

[knative-prow]

@twoGiants: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
upgrade-tests_eventing-kafka-broker_main	94b34ac	link	true	/test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.