Skip to content

Fix: don't publish pod annotation update failure events. #4548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: don't publish pod annotation update failure events. #4548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions control-plane/pkg/reconciler/base/receiver_condition_set.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import (
"fmt"
"net/url"

corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/client-go/tools/record"
"knative.dev/pkg/apis"
Expand Down Expand Up @@ -216,20 +215,6 @@ func (manager *StatusConditionManager) Addressable(address *url.URL) {
manager.ProbesStatusReady()
}

func (manager *StatusConditionManager) FailedToUpdateDispatcherPodsAnnotation(err error) {

// We don't set status conditions for dispatcher pods updates.

// Record the event.
manager.Recorder.Eventf(
manager.Object,
corev1.EventTypeWarning,
"failed to update dispatcher pods annotation",
"%v",
err,
)
}

func (manager *StatusConditionManager) FailedToUpdateReceiverPodsAnnotation(err error) reconciler.Event {

return fmt.Errorf("failed to update receiver pods annotation: %w", err)
Expand Down
2 changes: 0 additions & 2 deletions control-plane/pkg/reconciler/broker/broker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,6 @@ func (r *Reconciler) reconcileKind(ctx context.Context, broker *eventing.Broker)
"Failed to update dispatcher pod annotation to trigger an immediate config map refresh",
zap.Error(err),
)

statusConditionManager.FailedToUpdateDispatcherPodsAnnotation(err)
} else {
logger.Debug("Updated dispatcher pod annotation")
}
Expand Down
2 changes: 0 additions & 2 deletions control-plane/pkg/reconciler/trigger/trigger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,6 @@ func (r *Reconciler) reconcileKind(ctx context.Context, trigger *eventing.Trigge
"Failed to update dispatcher pod annotation to trigger an immediate config map refresh",
zap.Error(err),
)

statusConditionManager.failedToUpdateDispatcherPodsAnnotation(err)
} else {
logger.Debug("Updated dispatcher pod annotation")
}
Expand Down
14 changes: 0 additions & 14 deletions control-plane/pkg/reconciler/trigger/trigger_lifecycle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,20 +109,6 @@ func (m *statusConditionManager) failedToResolveTriggerConfig(err error) reconci
return fmt.Errorf("failed to resolve trigger config: %w", err)
}

func (m *statusConditionManager) failedToUpdateDispatcherPodsAnnotation(err error) {

// We don't set status conditions for dispatcher pods updates.

// Record the event.
m.Recorder.Eventf(
m.Trigger,
corev1.EventTypeWarning,
"Failed to update dispatcher pods annotation",
"%v",
err,
)
}

func (m *statusConditionManager) subscriberResolved(egress *contract.Egress) {
m.Trigger.GetConditionSet().Manage(&m.Trigger.Status).MarkTrueWithReason(
eventing.TriggerConditionSubscriberResolved,
Expand Down
Loading