Skip to content

Bump Apache Kafka to 4.0.0 #4475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Bump Apache Kafka to 4.0.0 #4475

wants to merge 4 commits into from

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Aug 6, 2025 •
edited
Loading

Go with Apache Kafka 4 and tweaking timeouts / test config

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 6, 2025
@knative-prow knative-prow bot requested review from Cali0707 and pierDipi August 6, 2025 14:48
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/test labels Aug 6, 2025
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane labels Aug 6, 2025
@codecov Codecov
Copy link

codecov bot commented Aug 6, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 29.96%. Comparing base (198c1fe) to head (828e2d6).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4475   +/-   ##
=======================================
  Coverage   29.96%   29.96%           
=======================================
  Files         290      290           
  Lines       19435    19435           
=======================================
  Hits         5823     5823           
  Misses      13159    13159           
  Partials      453      453

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matzew matzew force-pushed the bump_strimzi_0.46.1_kafka_4 branch from 7864249 to d4871d5 Compare August 7, 2025 14:52
@matzew
Copy link
Contributor Author

matzew commented Aug 8, 2025

/test reconciler-tests

matzew added 2 commits August 12, 2025 07:08
@matzew
🎉 Bump to Apache Kafka 4+
916c6d8 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
Removing deprecated DefaultPartition configuration. Strimz does not e…
3e9475e 
…ven support older versions like 3.2, where this was not deprecated

Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew matzew force-pushed the bump_strimzi_0.46.1_kafka_4 branch from d4871d5 to 3e9475e Compare August 12, 2025 05:08
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 12, 2025
@matzew matzew changed the title WIP: Bump strimzi 0.46.1 kafka 4 WIP: Bump Apache Kafka to 4.0.0 Aug 12, 2025
@matzew
Copy link
Contributor Author

matzew commented Aug 12, 2025

/test reconciler-tests

@matzew
Copy link
Contributor Author

matzew commented Aug 12, 2025

on the integration test

          "receivedCount": 16263,
          "terminated": true,
          "metrics": {
            "proposedCount": 18000,
            "acceptedCount": 18000,

or in the reconciler test

 "receivedCount": 12865,
          "terminated": true,
          "metrics": {
            "proposedCount": 18000,
            "acceptedCount": 18000,
            "metrics": {

@matzew
Copy link
Contributor Author

matzew commented Aug 12, 2025

/retest

@matzew
Tweaks on cfg
e79e4b7 
Signed-off-by: Matthias Wessendorf <[email protected]>
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 12, 2025
@matzew
Copy link
Contributor Author

matzew commented Aug 12, 2025

/retest

@matzew matzew changed the title WIP: Bump Apache Kafka to 4.0.0 Bump Apache Kafka to 4.0.0 Aug 12, 2025
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 12, 2025
@matzew
Copy link
Contributor Author

matzew commented Aug 13, 2025

/test integration-tests

matzew
matzew commented Aug 13, 2025
View reviewed changes
data-plane/config/broker/100-config-kafka-broker-data-plane.yaml
linger.ms=0
max.block.ms=60000
max.request.size=1048576
partitioner.class=org.apache.kafka.clients.producer.internals.DefaultPartitioner
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this API is deprecated since 3.2 - and removed w/ kafka 4

@matzew
Copy link
Contributor Author

matzew commented Aug 13, 2025

/test integration-tests

@matzew
Bump timeout
828e2d6 
Signed-off-by: Matthias Wessendorf <[email protected]>
@matzew
Copy link
Contributor Author

matzew commented Aug 14, 2025

/retest-required

@matzew
Copy link
Contributor Author

matzew commented Aug 15, 2025

/retest

1 similar comment
@matzew
Copy link
Contributor Author

matzew commented Aug 20, 2025

/retest

@Cali0707
Copy link
Member

/test reconciler-tests
/test integration-tests

@matzew
Copy link
Contributor Author

matzew commented Aug 27, 2025

/retest

@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 27, 2025

@matzew: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests_eventing-kafka-broker_main 828e2d6 link true /test reconciler-tests
integration-tests_eventing-kafka-broker_main 828e2d6 link true /test integration-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Awaiting requested review from Cali0707

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane area/test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matzew @Cali0707