Allow inclusion of custom redirect_uri when configuring provider #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
one year ago... will be fine to get it merged @kmrshntr |
ginjo
added a commit
to ginjo/omniauth-slack
that referenced
this pull request
Aug 7, 2018
Update README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain scenarios (for instance when coming from a slack team style subdomain) we want the ability to set a custom redirect_uri, since Slack doesn't allow a wildcard for the subdomain.
Example: Your application allows creation of arbitrary team subdomains (exactly how Slack works). The user clicks the Add to Slack from
subdomain1.example.com. However the allowable redirect_uri in the Slack App settings iswww.example.com/slack/*. This will break because the gem will currently set the redirect_uri from the current location.