Skip to content

Conversation

mohammedahmed18
Copy link
Contributor

jozu-login

@gorkem gorkem requested a review from Copilot August 2, 2025 10:46
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects the login prompt for the jozu.ml registry by changing the username prompt to "Email:" instead of "Username:" when logging into jozu.ml specifically.

  • Updates the username prompt to "Email:" when the registry is "jozu.ml"
  • Maintains backward compatibility by keeping "Username:" for all other registries

if username == "" {
username, err = util.PromptForInput("Username: ", false)
usernamePrompt := "Username: "
if opts.registry == "jozu.ml" {
Copy link
Preview

Copilot AI Aug 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard-coding the registry name "jozu.ml" creates a magic string that could be error-prone. Consider defining this as a constant (e.g., const JozuMLRegistry = "jozu.ml") to improve maintainability and reduce the risk of typos.

Suggested change
if opts.registry == "jozu.ml" {
if opts.registry == jozuMLRegistry {

Copilot uses AI. Check for mistakes.

@gorkem
Copy link
Member

gorkem commented Aug 2, 2025

May be this would work better if it was a url-to-label map that could be utilized for other registries.

Signed-off-by: mohammed <[email protected]>
Signed-off-by: mohammed <[email protected]>
Signed-off-by: mohammed <[email protected]>
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should start special-casing different registries to ensure we're showing the correct term here. On jozu.ml, your username is your email -- the credentials you use when logging into the service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants