-
Notifications
You must be signed in to change notification settings - Fork 139
Correct username prompt for logging in to jozu.ml #936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Correct username prompt for logging in to jozu.ml #936
Conversation
mohammedahmed18
commented
Aug 1, 2025

Signed-off-by: mohammed <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects the login prompt for the jozu.ml registry by changing the username prompt to "Email:" instead of "Username:" when logging into jozu.ml specifically.
- Updates the username prompt to "Email:" when the registry is "jozu.ml"
- Maintains backward compatibility by keeping "Username:" for all other registries
pkg/cmd/login/cmd.go
Outdated
if username == "" { | ||
username, err = util.PromptForInput("Username: ", false) | ||
usernamePrompt := "Username: " | ||
if opts.registry == "jozu.ml" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard-coding the registry name "jozu.ml" creates a magic string that could be error-prone. Consider defining this as a constant (e.g., const JozuMLRegistry = "jozu.ml"
) to improve maintainability and reduce the risk of typos.
if opts.registry == "jozu.ml" { | |
if opts.registry == jozuMLRegistry { |
Copilot uses AI. Check for mistakes.
May be this would work better if it was a url-to-label map that could be utilized for other registries. |
Signed-off-by: mohammed <[email protected]>
Signed-off-by: mohammed <[email protected]>
Signed-off-by: mohammed <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should start special-casing different registries to ensure we're showing the correct term here. On jozu.ml
, your username is your email -- the credentials you use when logging into the service.