-
Notifications
You must be signed in to change notification settings - Fork 0
fix: set to specific config file linter, formatter and use main as auto pr request branch #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set to specific config file linter, formatter and use main as auto pr request branch #104
Conversation
WalkthroughThis pull request updates various configuration and documentation files. The ESLint configuration in Changes
Possibly related PRs
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
src/pages/docs/drowser/roadmap.mdx (2)
4-4
: Add a comma after "For now" for better readability.-For now we don't have a roadmap, but we are working on it. Stay tuned! +For now, we don't have a roadmap, but we are working on it. Stay tuned!
1-4
: Consider enhancing the roadmap placeholder content.While the current message is clear, consider adding more context about planned features or development direction to set user expectations.
Example enhancement:
# Roadmap - -For now we don't have a roadmap, but we are working on it. Stay tuned! +While our detailed roadmap is still in development, we're actively working on: + +- Improving documentation +- Enhancing user experience +- Adding new features + +Stay tuned for updates! We welcome your feedback and suggestions.🧰 Tools
🪛 LanguageTool
[typographical] ~3-~3: Consider adding a comma here.
Context: # Roadmap For now we don't have a roadmap, but we are wor...(FOR_NOW_COMMA)
package.json (1)
1-38
: Configuration Externalization and CleanupThe removal of the inline ESLint and Prettier configuration blocks from this file (as noted in the PR summary) improves modularity by delegating configurations to dedicated files (i.e.,
.eslintrc.json
and.prettierrc.json
). Please ensure that these new files are correctly configured and referenced throughout the project.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (6)
.eslintrc.json
(1 hunks).github/workflows/pr.yml
(2 hunks).prettierrc.json
(1 hunks)package.json
(1 hunks)src/pages/docs/drowser/_meta.ts
(1 hunks)src/pages/docs/drowser/roadmap.mdx
(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- .prettierrc.json
- .eslintrc.json
🧰 Additional context used
🪛 LanguageTool
src/pages/docs/drowser/roadmap.mdx
[typographical] ~3-~3: Consider adding a comma here.
Context: # Roadmap For now we don't have a roadmap, but we are wor...
(FOR_NOW_COMMA)
🔇 Additional comments (4)
src/pages/docs/drowser/_meta.ts (1)
1-9
: LGTM! The meta object structure is well-organized.The changes simplify the key names and follow a logical documentation flow, from installation to changelog. The addition of the roadmap section enhances the documentation structure.
.github/workflows/pr.yml (2)
6-6
: Align Branch Ignoring with Updated StrategyThe workflow now ignores pushes on the
main
branch instead ofdevelop
. This update aligns with the new branch management strategy and prevents the workflow from triggering on changes to the main branch.
16-16
: Updated Automatic PR BranchThe environment variable
PULL_REQUEST_BRANCH
has been updated tomain
(previouslydevelop
). This change ensures that the generated pull requests usemain
as the default branch, as intended.package.json (1)
33-33
: New Prettier Dependency AddedThe addition of
"prettier": "^3.5.1"
in thedevDependencies
section is correct and supports consistent code formatting. This change is in line with moving configuration from the inline settings to a dedicated configuration file.
This is an automated pull request for branch fix/remove-json-from-eslint-filetypes-and-set-main-auto-pr-branch
Summary by CodeRabbit