Skip to content

Downgrade platform requirement and link frameworks #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Downgrade platform requirement and link frameworks #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
83146df
Fix xcschemes
hi2gage Oct 18, 2024
6ff3737
downgrade platforms
hi2gage Oct 18, 2024
543843d
link libraries to package
hi2gage Oct 18, 2024
ac05b0c
changes to lib
hi2gage Oct 18, 2024
91327db
linkedFramework
hi2gage Oct 18, 2024
f99bcc2
revert naming
hi2gage Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .swiftpm/xcode/xcshareddata/xcschemes/LibFido2Swift.xcscheme
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1600"
version = "1.8">
version = "1.7">
<BuildAction
parallelizeBuildables = "YES"
buildImplicitDependencies = "YES"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of an annoyance thing. With this set to automatic the version = "1.8" will switch back and other across machines.

buildArchitectures = "Automatic">
buildImplicitDependencies = "YES">
<BuildActionEntries>
<BuildActionEntry
buildForTesting = "YES"
Expand Down
13 changes: 9 additions & 4 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import PackageDescription

let package = Package(
name: "LibFido2Swift",
platforms: [.macOS(.v13)],
platforms: [.macOS(.v10_15)],
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping this at minimum possible value is usually best for adoption

products: [
// Products define the executables and libraries a package produces, making them visible to other packages.
.library(
Expand All @@ -18,10 +18,15 @@ let package = Package(
.target(
name: "LibFido2Swift",
dependencies: ["LibCrypto", "libfido2", "LibCbor"],
path: "LibFido2Swift"
path: "LibFido2Swift",
linkerSettings: [
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the explicit linking

.linkedFramework("LibCbor"),
.linkedFramework("LibCrypto"),
.linkedFramework("libfido2"),
]
),
.binaryTarget(name: "LibCbor", path: "./Frameworks/LibCbor.xcframework"),
.binaryTarget(name: "LibCrypto", path: "./Frameworks/LibCrypto.xcframework"),
.binaryTarget(name: "LibCbor", path: "./Frameworks/libCbor.xcframework"),
.binaryTarget(name: "LibCrypto", path: "./Frameworks/libCrypto.xcframework"),
.binaryTarget(name: "libfido2", path: "./Frameworks/libfido2.xcframework"),
]
)