This repository was archived by the owner on Dec 27, 2023. It is now read-only.
Update to accommodate DST longer than 255 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lodder <[email protected]>
Signed-off-by: Michael Lodder <[email protected]>
Signed-off-by: Michael Lodder <[email protected]>
AnomalRoil
reviewed
Jun 20, 2023
AnomalRoil
left a comment
AnomalRoil
left a comment
There was a problem hiding this comment.
Overall looks like a fine API to me, but the tests don't seem to test this new code path, which is suboptimal.
| @@ -1,5 +1,5 @@ | |||
| module github.com/kilic/bls12-381 | |||
| module github.cbhq.net/security/bls12-381 | |||
There was a problem hiding this comment.
This seems like it was committed by mistake.
| t.Fatal("encode to point fails x", i) | ||
| } | ||
| } | ||
| domain = []byte("QUUX-V01-CS02-with-expander") |
There was a problem hiding this comment.
This looks like a 27 bytes = 216 bit DST, so this does not test the code path about the DST being longer than 255, does it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Lodder [email protected]