Skip to content

Conversation

@dpapperini
Copy link

Pinning the transformers library to version 4.53.3 to avoid a breaking change introduced in version 4.54.0 that affects the ComfyUI-HunyuanVideoWrapper custom node.

This change addresses the issues reported, such as the one in #497.

The transformers requirement has been updated from transformers>=4.49.0 to transformers>=4.49.0,<=4.53.3 to ensure compatibility while still allowing minor updates within a known stable range.

Pinning the transformers library to version 4.53.3 to avoid a breaking change introduced in version 4.54.0 that affects the ComfyUI-HunyuanVideoWrapper custom node. 

This change addresses the issues reported, such as the one in kijai#497.

The transformers requirement has been updated from transformers>=4.49.0 to transformers>=4.49.0,<=4.53.3 to ensure compatibility while still allowing minor updates within a known stable range.
@Draek2077
Copy link

Do you have to pin this library? You just have to remove the use of _validate_images_text_input_order which was deprecated and removed from the library. Everything works otherwise from what I can tell. This removes the error loading the node.

@dpapperini
Copy link
Author

Hi @Draek2077,

Do you have to pin this library? You just have to remove the use of _validate_images_text_input_order which was deprecated and removed from the library. Everything works otherwise from what I can tell. This removes the error loading the node.

Thanks for raising this. You make a great point. I agree that removing the deprecated function _validate_images_text_input_order is a more sustainable solution than pinning the library version.

My PR's intent was to provide a quick and safe fix for users who were running into issues, without requiring a change to the node's code.

However, a long-term approach should definitely be to update the code to be compatible with the latest versions. Creating a separate PR to address this specific change would be a great idea.

Thanks again for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants