Make it possible to run without EventHeader collection when converting from EDM4hep to LCIO #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
fix-required-eventheader
branch
2 times, most recently
from
5c57c2f to
48a87c9
Compare
To verify that without fix we get an error here
Warn otherwise
tmadlener
force-pushed
the
fix-required-eventheader
branch
from
48a87c9 to
e3ddcc9
Compare
tmadlener
commented
Oct 10, 2025
| debug() << edm4hep::labels::EventHeader << " collection available. Converting it." << endmsg; | ||
| m_collsToConvert.emplace_back(edm4hep::labels::EventHeader, "<directly into LCEvent>"); | ||
| } else { | ||
| warning() << "The " << edm4hep::labels::EventHeader << " collection is not available. Not converting it." |
There was a problem hiding this comment.
Not sure if this is worth a warning, or whether we should make this info instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
EventHeadercollection when converting from EDM4hep to LCIO.ENDRELEASENOTES
This has been converted unconditionally up until now. This also means that the whole run fails if the collection is missing. Now we check (for the first event), whether we have an
EventHeadercollection and only then add it to the conversion by default even if it's unspecified by the user.k4DataSvcin tests where it's not explicitly needed #252