fix: use overlapped on windows get_descriptor #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erkki-silvola
force-pushed
the
fix-windows-get-descriptor-timeout
branch
9 times, most recently
from
5b9d23c to
c391ba7
Compare
Contributor
Author
|
@kevinmehall I would like to get your thoughts around this. |
erkki-silvola
force-pushed
the
fix-windows-get-descriptor-timeout
branch
from
c391ba7 to
b9d8905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider draft, Non polished. Attempt to add support on windows get_descriptor timeout, also I saw the other PR's (though different approach) related to this so decided not spend too much time on this. I do admit there might be some caveat with using overlapped.