Fix job submission for ChromeBooks #1329
Open
+68
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `base_name` attribute is now used (when present) as the LAVA device type, similarly to its usage in the legacy KernelCI. However, this breaks job submission for ChromeBooks as we used this attribute in a different way and relied on jobs to be submitted with the platform name being used as device type. In order to fix this, drop `base_name` entirely from all ChromeBook platform definitions (this is an optional attribute anyway) so we default back to using the platform name as the LAVA device type. Also use a new `params[short_name]` attribute as a replacement for our previous use of `base_name` here. Signed-off-by: Arnaud Ferraris <[email protected]>
No need to redefine `base_name` for `qemu-arm` as this attribute is already part of the `qemu-device` anchor. Signed-off-by: Arnaud Ferraris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
base_nameattribute is now used (when present) as the LAVA devicetype, similarly to its usage in the legacy KernelCI. However, this
breaks job submission for ChromeBooks as we used this attribute in a
different way and relied on jobs to be submitted with the platform name
being used as device type.
In order to fix this, drop
base_nameentirely from all ChromeBookplatform definitions (this is an optional attribute anyway) so we
default back to using the platform name as the LAVA device type. Also
use a new
params[short_name]attribute as a replacement for ourprevious use of base_name here.
This PR also includes a tiny improvement to the
qemu-armplatform definition.