kernelci: kbuild: transition to available state when complete
#2882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: kernelci/kernelci-pipeline#1164 should be merged first, adding a note in the PR description. |
nuclearcat
reviewed
May 24, 2025
nuclearcat
added
the
staging-skip
Currently, `kbuild` nodes transition to state `done` as soon as they complete, even though they often have many child nodes running afterwards. This is confusing as `checkout` nodes first transition to `available` state, then `closing` (waiting for child nodes to complete) and only transition to `done` once all child nodes have completed. This behaviour should be applied to `kbuild` nodes as well, both for consistency and to be able to easily schedule post-processing jobs (e.g. by triggering those on the `state: done` event). Also add a `holdoff` value (10 minutes, identical to `checkout` nodes) so the corresponding service properly handles state transitions for those nodes. Fixes kernelci#2875 Signed-off-by: Arnaud Ferraris <[email protected]>
a-wai
force-pushed
the
mark-kbuild-available
branch
from
723a578 to
2ce7576
Compare
`submit_results()` currently ignores fields such as `state` and `holdoff` from the results, leading to unexpected results when those are set prior to calling this function. Ensure both those fields are copied over with sane defaults. Signed-off-by: Arnaud Ferraris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
kbuildnodes transition to statedoneas soon as they complete, even though they often have many child nodes running afterwards. This is confusing ascheckoutnodes first transition toavailablestate, thenclosing(waiting for child nodes to complete) and only transition todoneonce all child nodes have completed.This behaviour should be applied to
kbuildnodes as well, both for consistency and to be able to easily schedule post-processing jobs (e.g. by triggering those on thestate: doneevent).Also add a
holdoffvalue (10 minutes, identical tocheckoutnodes) so the corresponding service properly handles state transitions for those nodes.Fixes #2875
Depends on kernelci/kernelci-pipeline#1164