Skip to content

[OpenVINO Backend] update slice method #21361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025

Conversation

Mohamed-Ashraf273
Copy link
Contributor

Hi @rkazants
I've updated ops.slice to support OpenVINOKerasTensor slicing, which I need for the GSoC project.
Could you please review it?
Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.72%. Comparing base (771b001) to head (40adae6).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/backend/openvino/core.py 73.68% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21361      +/-   ##
==========================================
+ Coverage   82.70%   82.72%   +0.02%     
==========================================
  Files         565      565              
  Lines       54894    54909      +15     
  Branches     8517     8522       +5     
==========================================
+ Hits        45398    45424      +26     
+ Misses       7415     7398      -17     
- Partials     2081     2087       +6     
Flag Coverage Δ
keras 82.53% <73.68%> (+0.02%) ⬆️
keras-jax 63.55% <0.00%> (-0.02%) ⬇️
keras-numpy 58.71% <0.00%> (-0.02%) ⬇️
keras-openvino 33.58% <73.68%> (+0.04%) ⬆️
keras-tensorflow 63.94% <0.00%> (-0.02%) ⬇️
keras-torch 63.58% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mohamed-Ashraf273 Mohamed-Ashraf273 force-pushed the update_slice branch 2 times, most recently from 185a9b2 to 29fb28c Compare June 6, 2025 22:36
Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet, looks good to me. Recommend to merge

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jun 9, 2025
@fchollet fchollet merged commit f379556 into keras-team:master Jun 9, 2025
7 checks passed
@Mohamed-Ashraf273 Mohamed-Ashraf273 deleted the update_slice branch June 10, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run ready to pull Ready to be merged into the codebase size:S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants