-
Notifications
You must be signed in to change notification settings - Fork 19.6k
WIP: fix RandAugment behavior in tf graph mode #21185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21185 +/- ##
==========================================
- Coverage 82.69% 73.11% -9.58%
==========================================
Files 564 564
Lines 54226 54404 +178
Branches 8425 8448 +23
==========================================
- Hits 44840 39776 -5064
- Misses 7310 12711 +5401
+ Partials 2076 1917 -159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In my opinion, some exception handling should be added for the NumPy backend in your test case, particularly due to the use of the fit method. |
yes I agree, the test should be skipped for numpy backend. Any ideas about the layer implementation? it seems to have problems for jax backend |
I’m not entirely sure about that. I think a step-by-step breakdown is needed to identify what’s causing the slowdown in the JAX backend. |
Ok I will take a look when I get a chance. |
fix for #21169
RandAugment
changes:fori
andswitch
to execute the sub layers according to the sampled orderthis is passing the tests in all three backends. However for the
test_rand_augment_model
test, jax runs very slowly, way slower than the other backends, by a factor of 10 - 50. I have no experience with jax, can you suggest anything that might help?thanks