Skip to content

[OpenVINO BACKEND] - feat: implement numpy.nonzero for openvino backend #21163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025

Conversation

11happy
Copy link
Contributor

@11happy 11happy commented Apr 14, 2025

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.58%. Comparing base (c7b6b42) to head (5ddafe0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21163   +/-   ##
=======================================
  Coverage   82.58%   82.58%           
=======================================
  Files         564      564           
  Lines       54398    54401    +3     
  Branches     8449     8449           
=======================================
+ Hits        44926    44929    +3     
  Misses       7397     7397           
  Partials     2075     2075           
Flag Coverage Δ
keras 82.39% <100.00%> (+<0.01%) ⬆️
keras-jax 63.80% <0.00%> (-0.01%) ⬇️
keras-numpy 58.91% <0.00%> (-0.01%) ⬇️
keras-openvino 32.93% <100.00%> (+<0.01%) ⬆️
keras-tensorflow 64.21% <0.00%> (-0.01%) ⬇️
keras-torch 63.89% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@11happy
Copy link
Contributor Author

11happy commented Apr 14, 2025

openvino tests are passing : ) ,
pre-commit is failing due openvino.runtime will be deprecated issue, openvino.runtime is utilised in 38 places in 7 files so should I replace them all ?
Thank you

@rkazants
Copy link
Contributor

openvino tests are passing : ) , pre-commit is failing due openvino.runtime will be deprecated issue, openvino.runtime is utilised in 38 places in 7 files so should I replace them all ? Thank you

please try to merge latest master

@11happy
Copy link
Contributor Author

11happy commented Apr 15, 2025

I have rebased my branch on latest master.
Thank you

Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet, looks good to me. Recommend to merge.

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 16, 2025
@fchollet
Copy link
Collaborator

This branch has conflicts that must be resolved

Please resolve merge conflicts in keras/src/backend/openvino/excluded_concrete_tests.txt.

@rkazants
Copy link
Contributor

This branch has conflicts that must be resolved

Please resolve merge conflicts in keras/src/backend/openvino/excluded_concrete_tests.txt.

@11happy, fyi

@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Apr 17, 2025
@11happy
Copy link
Contributor Author

11happy commented Apr 17, 2025

Done : )
resolved the merge conflict.
Thank you

@rkazants
Copy link
Contributor

@fchollet, looks good to me. Recommend to merge.

@fchollet fchollet merged commit 65f7e6d into keras-team:master Apr 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Good First Issue][Keras 3 OpenVINO Backend]: Support numpy.nonzero operation
6 participants