[OpenVino BackEnd] support np.diagnol for ov BackEnd #21156
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21156 +/- ##
==========================================
- Coverage 82.59% 79.85% -2.74%
==========================================
Files 564 564
Lines 54407 54477 +70
Branches 8449 8459 +10
==========================================
- Hits 44936 43503 -1433
- Misses 7396 8959 +1563
+ Partials 2075 2015 -60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@fchollet, sir I feel like my code is not upto the best standards will it be possible to ask for your guidance regarding the same? |
|
|
||
| if node_rank < 2: | ||
| raise ValueError( | ||
| "Input tensor must have at least rank 2 for diagonal extraction." |
There was a problem hiding this comment.
In such error messages, specify the shape that was passed (makes debugging easier)
There was a problem hiding this comment.
Understood sir will do any other changes that I should make?
There was a problem hiding this comment.
In such error messages, specify the shape that was passed (makes debugging easier)
I hope it is right now sir!
| @@ -81,7 +81,6 @@ NumpyOneInputOpsCorrectnessTest::test_conj | |||
| NumpyOneInputOpsCorrectnessTest::test_correlate | |||
There was a problem hiding this comment.
please also remove NumpyDtypeTest::test_diag line
There was a problem hiding this comment.
Sir should I implement Diag as well?
There was a problem hiding this comment.
you can see a line NumpyDtypeTest::test_diag above in this file. Please remove it as well to switch on tests
|
@rkazants Sir, everything from my side is now done please check n confirm the error is due to diag not being implemented yet. |
@fchollet, could you please review?