[Keras 3 OpenVINO Backend]: Support numpy.log1p operation #29487 #21129
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21129 +/- ##
========================================
Coverage 82.68% 82.69%
========================================
Files 564 564
Lines 54132 54232 +100
Branches 8411 8425 +14
========================================
+ Hits 44761 44846 +85
- Misses 7296 7310 +14
- Partials 2075 2076 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Do not merge. Quite massive amount of changes. |
|
@rkazants What can I do about this ? any suggestions ? |
This reverts commit 2b880fa.
rkazants
reviewed
Apr 14, 2025
| @@ -33,7 +33,6 @@ NumpyDtypeTest::test_isfinite | |||
| NumpyDtypeTest::test_isinf | |||
| NumpyDtypeTest::test_isnan | |||
| NumpyDtypeTest::test_linspace | |||
| NumpyDtypeTest::test_log1p | |||
| NumpyDtypeTest::test_logaddexp | |||
| NumpyDtypeTest::test_logspace | |||
There was a problem hiding this comment.
please also remove NumpyOneInputOpsCorrectnessTest::test_log1p below
|
also, correct formatting: |
rkazants
reviewed
Apr 14, 2025
| one_const = ov_opset.constant(1, x_type).output(0) | ||
| added = ov_opset.add(x, one_const).output(0) | ||
| result = ov_opset.log(added).output(0) | ||
| return OpenVINOKerasTensor(result) | ||
|
|
There was a problem hiding this comment.
please add more one blank line to pass CI jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rkazants
Details: Added support numpy.log1p operation and a successful test run. Code
can you review please ? also i tried to fix the pre-commit run error but could not solve it, can you please help me with it ?