-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Fix for issue #21118: inconsistent behavior across callbacks #21124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix for issue #21118: inconsistent behavior across callbacks #21124
Conversation
…d logic used in EarlyStopping.
…d logic used in EarlyStopping
…d logic used in EarlyStopping
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21124 +/- ##
==========================================
- Coverage 82.69% 82.69% -0.01%
==========================================
Files 564 564
Lines 54132 54152 +20
Branches 8411 8420 +9
==========================================
+ Hits 44765 44779 +14
- Misses 7294 7297 +3
- Partials 2073 2076 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @adar21a Can you please sign CLA? Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Please add a unit test for the fixed use cases.
#21118