Implement OpenVINO Decomposition for numpy.hstack Operation #21017
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21017 +/- ##
=======================================
Coverage 82.55% 82.55%
=======================================
Files 564 564
Lines 54638 54649 +11
Branches 8497 8500 +3
=======================================
+ Hits 45105 45116 +11
Misses 7442 7442
Partials 2091 2091
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
a lot of unneeded changes: Please fix it. |
|
check if it is fine now.. i changed the branch |
|
hello @rkazants, |
keras/src/backend/openvino/numpy.py
Outdated
| if not isinstance(xs, (list, tuple)): | ||
| raise TypeError("Input to `hstack` must be a list or tuple of tensors.") | ||
| if len(xs) == 0: | ||
| raise ValueError("Input list to `hstack` cannot be empty.") |
There was a problem hiding this comment.
please remove, not needed checks. TF backend does not have such check for hstack implementation.
keras/src/backend/openvino/numpy.py
Outdated
| if not isinstance(xs, (list, tuple)): | ||
| raise TypeError("Input to `hstack` must be a list or tuple of tensors.") | ||
| if len(xs) == 0: | ||
| raise ValueError("Input list to `hstack` cannot be empty.") |
There was a problem hiding this comment.
| if not isinstance(xs, (list, tuple)): | |
| raise TypeError("Input to `hstack` must be a list or tuple of tensors.") | |
| if len(xs) == 0: | |
| raise ValueError("Input list to `hstack` cannot be empty.") |
keras/src/backend/openvino/numpy.py
Outdated
| element_type = x.output.get_element_type() | ||
| break | ||
| xs = [get_ov_output(x, element_type) for x in xs] | ||
| xs = _align_operand_types(xs[0], xs[1], "hstack()") |
There was a problem hiding this comment.
here you align only first two elements but it does not cover a case of list with three elements and more. Please align all of them to xs[0] and then call concat
|
ok got it sir. |
github-project-automation
bot
moved this from Assigned Reviewer
to Closed/Rejected
in PR Queue
github-project-automation
bot
moved this from Closed/Rejected
to Assigned Reviewer
in PR Queue
Hmm-1224
force-pushed
the
main
branch
2 times, most recently
from
35de273 to
4957517
Compare
|
Hello @rkazants, |
|
Hii @rkazants, |
github-project-automation
bot
moved this from Assigned Reviewer
to Closed/Rejected
in PR Queue
@rkazants, please check out this PR