This repository was archived by the owner on Jun 30, 2021. It is now read-only.
Enhancement: Add file_fingerprint_lines option #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
define service_name as parameter as it is different depending on OS (especially AmazonLinux2LTS)
amazonlinux2 support
|
Do I need to do anything special to get this reviewed and, hopefully, merged? |
|
Still looking for a merge on this request. Has anyone found any issues that need to be resolved before this can be completed? |
|
Can someone please review and comment on this pull request? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding file fingerprint as described in the AWS documentation, but not yet available in this module.
Updated README.md and added appropriate lines to files, with formatting tweaks.
This addresses a case where the service fails to recognize file rotation when the first line of the file is an identical "banner" line causing a stale state with no new uploads going to CloudWatch.
Sample data from log file: