fix: update DeltaTableDataset.py updating the from data catalog metho… #1202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d for deltalake v1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changing the from_data_catalog method as it is removed from the deltaLake library of new version
Description
SLOVED THE ISSUE: #1092
now for new ones as we only use aws and unity catalog types I have updated the from_data_catalog metod , as the New DeltaTable method only accepts table uri and configs and as it not accepts the data catalog and etc args so I removed the from_data_catalog method to table_uri generating and sending it to the DeltaTable method I could also go to another method like removing like removing all the data_catalog types and data_catalog_id arguments and only allowing user to send the table_uri but as we were only using AWS and unity I had to deviate from hardcore changes and the test cases need to be updated for the new methods