Skip to content

Conversation

@wozniakjan
Copy link
Member

@wozniakjan wozniakjan commented Nov 20, 2025

This PR contains two minor changes

Checklist

@snyk-io
Copy link

snyk-io bot commented Nov 20, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@wozniakjan wozniakjan force-pushed the interceptor_make_request_logging_optional branch 5 times, most recently from ec1584b to 82012da Compare November 20, 2025 09:53
@wozniakjan wozniakjan marked this pull request as ready for review November 20, 2025 10:07
@wozniakjan wozniakjan requested a review from Copilot November 20, 2025 10:07
Copilot finished reviewing on behalf of wozniakjan November 20, 2025 10:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes interceptor request logging optional by introducing a new environment variable KEDA_HTTP_LOG_REQUESTS that defaults to false, addressing performance and log verbosity concerns in production environments.

Key changes:

  • Added LogRequests configuration field to enable/disable request logging via KEDA_HTTP_LOG_REQUESTS environment variable
  • Modified logging middleware to accept an optional logger pointer and skip logging when nil
  • Added documentation for the new configuration option

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
interceptor/config/serving.go Added LogRequests boolean field with environment variable binding
interceptor/middleware/logging.go Changed logger to pointer type and added nil check to make logging optional
interceptor/main.go Conditionally initializes logger pointer based on LogRequests config
docs/operate.md Added documentation section for request logging configuration
CHANGELOG.md Updated with improvement entry for optional request logging
.github/workflows/linkinator.yaml Fixed lychee link checker argument from --base-url to --root-dir
.github/PULL_REQUEST_TEMPLATE.md Corrected relative path to docs directory
.github/ISSUE_TEMPLATE/3_release_tracker.md Fixed malformed markdown link syntax

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wozniakjan wozniakjan requested review from a team November 20, 2025 10:13
@wozniakjan wozniakjan enabled auto-merge (squash) November 20, 2025 10:20
@wozniakjan wozniakjan force-pushed the interceptor_make_request_logging_optional branch from 82012da to bb8c581 Compare November 20, 2025 12:47
@wozniakjan wozniakjan merged commit 72e2b36 into kedacore:main Nov 26, 2025
26 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants