two patches for btrfsmaintenance #130
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monthly make it align with the value in btrfs-balance.timer
configuration file exists When tuning the value BTRFS_BALANCE_PERIOD in /etc/sysconfig/btrfsmaintenance, btrfsmaintenance-refresh.service will be triggered. But sometimes it will fail because the script /usr/share/btrfsmaintenance/btrfsmaintenance-refresh-cron.sh claims the file /etc/sysconfig/btrfsmaintenance does not exist. Because there's a timing window between the service is triggered and the configuration file is checked. """ Setting up watches. Watches established. /etc/sysconfig/ OPEN /etc/sysconfig/ CLOSE_NOWRITE,CLOSE /etc/sysconfig/ OPEN /etc/sysconfig/ ACCESS /etc/sysconfig/ CLOSE_NOWRITE,CLOSE /etc/sysconfig/ MOVE_SELF /etc/sysconfig/ ATTRIB /etc/sysconfig/ DELETE_SELF """ As a result it will be chaos after the service file finishes. Reference: bsc#1235954
|
What's your motivation for the changes? What problems do they fix? |
I have updated the description for these two unrelated patches. Thanks for your reminding. |
|
If the patches are unrelated, they should probably be in separate pull requests. Note that movement is a little slow here. :-) The text in your first commit could probably make it more obvious that the default timer values are incorrectly different - and that this is in fact a fix to align the values. As is, it reads that you are making an arbitrary decision when that is not true. |
|
Please split the changes to two patches (in one pull request). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the first patch, when this package was first installed, the timer will be scheduled as monthly for btrfs-balance.service. However if the user modifies configuration options other than BTRFS_BALANCE_PERIOD in /etc/sysconfig/btrfsmaintenance, the timer will be changed to weekly without being noticed. To avoid such a case, it's better to keep the value in the .timer file and the configuration file same.
For the second patch, it tries to fix a timing window when editing the configuration file /etc/sysconfig/btrfsmaintenance. Please refer to the patch description for more detail.