[PATCH v3] btrfs-progs: add slack space for mkfs --shrink #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a flag `--shrink-slack-size SIZE` to the mkfs.btrfs allowing users to specify slack when shrinking the filesystem. Previously if you wanted to use --shrink and include extra space in the filesystem you would need to use btrfs resize, however, this requires mounting the filesystem which requires CAP_SYS_ADMIN. The new syntax is: `mkfs.btrfs --shrink --shrink-slack-size SIZE` Where slack size is an argument specifying the desired free space to add to a shrunk fs. If not provided, the default slack size is 0. V3: - warn if block device size < fs size V2: - change --shrink[=SLACK SIZE] to --shrink-slack-size SIZE - check for slack size alignment - fix formatting - remove new_size > device size warning message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a flag
--shrink-slack-size SIZEto the mkfs.btrfs allowing users to specify slack when shrinking the filesystem. Previously if you wanted to use --shrink and include extra space in the filesystem you would need to use btrfs resize, however, this requires mounting the filesystem which requires CAP_SYS_ADMIN.The new syntax is:
mkfs.btrfs --shrink --shrink-slack-size SIZEWhere slack size is an argument specifying the desired free space to add to a shrunk fs. If not provided, the default slack size is 0.
V3: